Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement macros #113

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Implement macros #113

wants to merge 8 commits into from

Conversation

peterhinch
Copy link
Contributor

As per issue #111

@peterhinch peterhinch changed the title Implemnt macros Implement macros Sep 26, 2019
@peterhinch
Copy link
Contributor Author

@dhylands In response to your suggestion of a default macro file this is now implemented. Its name is rshell_macros.py and it should be located on the Python path. The contents of any user-specified macro file are added to those in any default. This is done by means of dict.update. Consequently in the case of identical macro names the specified file has priority.

I have not adopted your suggestion of ~/.rshellrc because macro files comprise Python source and should therefore conform to Python naming and search conventions. I would suggest that users of the macro facility will be experienced Python coders who will be familiar with and expect such conformance.

@dhylands dhylands force-pushed the master branch 3 times, most recently from 1861b2d to a28df4c Compare March 20, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant